Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if architectures is in the config before reading it #62

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

NohTow
Copy link
Collaborator

@NohTow NohTow commented Oct 9, 2024

When experimenting around, I realized that some models do not have "architectures" in their config (e.g, debertav3.

This PR just check if there is one before checking if it is a HF_ColBERT (and thus that the model is a stanford-nlp model).

@raphaelsty
Copy link
Collaborator

LGTM

@raphaelsty raphaelsty added the enhancement New feature or request label Oct 9, 2024
@raphaelsty raphaelsty merged commit 98c4e2b into main Oct 9, 2024
2 checks passed
@NohTow NohTow deleted the fix_roberta branch October 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants