Revert "removed unused linagora.esn.james module from inbox" #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienmoyon
approved these changes
May 25, 2021
|
can you fix admin spa ? we dont need to revert then if it works in inbox |
|
we revert it and we will move what we don't need in to the inbox-james for the admin SPA |
|
but this is not the spa admin. Do we need to keep james stuff inside inbox ? |
|
@atan-linagora for now let's revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #455
it seems the admin SPA can't build without it. so we might need to copy the james stuff in the admin SPA first.
or move it here https://github.com/linagora/esn-frontend-inbox-james