Healthcheck services in 'docker-openpaas-setup' docker compose file #1541
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoussemNasri
commented
Feb 16, 2025
tmail-backend/tmail-third-party/openpaas/src/test/resources/docker-openpaas-setup.yml
Outdated
Show resolved
Hide resolved
HoussemNasri
force-pushed
the
openpaas-docker-compose-healthcheck
branch
from
eaf8c85 to
6201d6a
Compare
vttranlina
reviewed
Feb 20, 2025
| start_period: 40s | ||
| interval: 10s | ||
| timeout: 10s | ||
| retries: 10 |
There was a problem hiding this comment.
we can modify the depends_on logic for increased effectiveness.
eg:
old
depends_on:
elasticsearchnew:
depends_on:
elasticsearch:
condition: service_healthy
vttranlina
reviewed
Feb 20, 2025
| @@ -1,4 +1,4 @@ | |||
| version: "2" | |||
| version: "2.7" | |||
There was a problem hiding this comment.
Is it fine to upgrade to version: '3' ? (similar to other docker-compose sample files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1537
I could not health check all services using the OpenPaas API
/api/healthcheck/{services}as some images don't have CURL installed. As a workaround, I’ve implemented custom health checks for these services