Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3222 Hide reply calendar event action buttons if email is event reply #3224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Oct 23, 2024

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3224.

@@ -356,6 +356,7 @@ extension CalendarEventExtension on CalendarEvent {
}

bool get isDisplayedEventReplyAction => method != null
&& method != EventMethod.reply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, what are other possible values here and for which others does it make sense to hide the buttuns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other possible values

Screenshot 2024-10-24 at 09 16 13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO

Publish: Hide
Request: Show
Reply: Hide
Add: Show
Cancel: Hide
Refresh: Hide
Counter: Show
DeclineCounter: Hide

@chibenwa How about you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants