-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3222 Hide reply calendar event action buttons if email is event reply #3224
base: master
Are you sure you want to change the base?
TF-3222 Hide reply calendar event action buttons if email is event reply #3224
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3224. |
@@ -356,6 +356,7 @@ extension CalendarEventExtension on CalendarEvent { | |||
} | |||
|
|||
bool get isDisplayedEventReplyAction => method != null | |||
&& method != EventMethod.reply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, what are other possible values here and for which others does it make sense to hide the buttuns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO
Publish: Hide
Request: Show
Reply: Hide
Add: Show
Cancel: Hide
Refresh: Hide
Counter: Show
DeclineCounter: Hide
@chibenwa How about you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
Reference
Resolved
Screen.Recording.2024-10-23.at.16.21.36.mov