💄Fix broken layout due to long folder/file name (#117 & #124) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepilov
reviewed
Jul 5, 2023
| @@ -104,10 +104,10 @@ export const DocumentRow = ({ | |||
| } | |||
| /> | |||
| </div> | |||
| <div className="grow text-ellipsis whitespace-nowrap overflow-hidden"> | |||
| <div className="grow text-ellipsis whitespace-nowrap overflow-hidden" style={{ width: '100px'}}> | |||
There was a problem hiding this comment.
do not use absolute values at all please, absolute values are eligible only for min and max style,
shepilov
reviewed
Jul 5, 2023
| <Base>{item.name}</Base> | ||
| </div> | ||
| <div className="shrink-0 ml-4"> | ||
| <div className="shrink-0 ml-4" style={{ width: '20px' }}> |
There was a problem hiding this comment.
and also, could you move the styles, to the styles file, or what is even better if it's possible to use existing classes from tailwind css
chibenwa
reviewed
Jul 6, 2023
| } else { | ||
| return name; | ||
| } | ||
| }else { |
There was a problem hiding this comment.
Suggested change
| }else { | |
| } else { |
| @@ -25,6 +25,18 @@ export default ({ | |||
| return <PathRender inTrash={inTrash || false} path={path} onClick={id => setParentId(id)} />; | |||
| }; | |||
|
|
|||
| function checkNamelength (name: any){ | |||
There was a problem hiding this comment.
function checkNamelength (name: any){
This is a bad name.
What are you "checking" for? Is checking even the best name here?
shepilov
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two issues were fixed:
The first one was when folder/file name were really long, the right layout with the 3 dots button was not on the screen. Now, if the name is too long, this button is still visible but not the whole name (in fact the name goes under the button and doesn't push it away)
The second one was when a folder had also a long name and you entered into it, the access path could also push the right layout out of the screen. Now, if the folder name is too long, it ends with ... in the access path to reduce it.
