Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Update the navigation bar/app grid #688

Merged
merged 4 commits into from
Oct 17, 2024
Merged

💄 Update the navigation bar/app grid #688

merged 4 commits into from
Oct 17, 2024

Conversation

MontaGhanmy
Copy link
Collaborator

The updated navigation bar

image

@MontaGhanmy MontaGhanmy self-assigned this Oct 11, 2024
@MontaGhanmy MontaGhanmy linked an issue Oct 11, 2024 that may be closed by this pull request
@shepilov
Copy link
Member

@MontaGhanmy there shouldn't be firts/last name in the app bar

@ericlinagora
Copy link
Contributor

it's itchy to my OCD that the middle column isn't aligned with the app grid button, is this on purpose ?

@shepilov
Copy link
Member

yes, it should be aligned right border of app menu icon

@ericlinagora
Copy link
Contributor

ericlinagora commented Oct 15, 2024

Is this the alignment we wanted ? (not a fan, but if that's the design...)

image

I don't think is correct, the idea was to put the email in this dropdown as a disabled entry:

image

not here:

image

And bonus if you change that dialog you'll have a fun merge time come webdav-express the already merged addition of Vietnamese and dark mode for that dialog.

@ericlinagora
Copy link
Contributor

image

it's there and not clickable (my account in that screen shot has no first/last name but email is [email protected] ), should we show the e-mail as well ? Is there a way to make it obvious it's not a normal context menu entry ?

@MontaGhanmy
Copy link
Collaborator Author

image

it's there and not clickable (my account in that screen shot has no first/last name but email is [email protected] ), should we show the e-mail as well ? Is there a way to make it obvious it's not a normal context menu entry ?

@ericlinagora It's not supposed to be clickable (it's text). The email is there is if COMPANY_DISPLAY_EMAIL is enabled (like the way it was before removing the name)
image

@MontaGhanmy MontaGhanmy merged commit 094d68a into main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] [Feature] New twp navigation bar
3 participants