[GROOMING-REVIEW] Contact sync v2 #2205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
hoangdat,
dab246 and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2205 |
hoangdat
reviewed
Jan 8, 2025
| this.status, | ||
| }); | ||
|
|
||
| String? calLookupAddress({required HashDetailsResponse hashDetails}) { |
There was a problem hiding this comment.
please separate function calculateHash(HashDetailsResponse hashDetails)
|
hoangdat
reviewed
Jan 16, 2025
| Map<String, List<String>> hashToContactIdMappings, | ||
| Map<String, Contact> contactIdToHashMap, | ||
| ) { | ||
| for (final contact in chunkContacts) { |
There was a problem hiding this comment.
we need 2 duplicated for loop? L40?
hoangdat
reviewed
Jan 16, 2025
| ); | ||
| } | ||
|
|
||
| Contact? processContacts( |
There was a problem hiding this comment.
specific in what kind of process?
Suggested change
| Contact? processContacts( | |
| Contact? calculateHashForContact( |
hoangdat
reviewed
Jan 16, 2025
Comment on lines
+110
to
+111
| Map<String, List<String>> phoneToHashMap, | ||
| Map<String, List<String>> emailToHashMap, |
hoangdat
reviewed
Jan 16, 2025
| final totalChunks = chunks.length; | ||
|
|
||
| yield await _handleLookupMappings( | ||
| progress: lookupChunkSize ~/ totalChunks, |
There was a problem hiding this comment.
why chunk size / totalChunks? it is constant number, it is not progress.
hoangdat
reviewed
Jan 16, 2025
|
|
||
| class GetPhonebookContactsSuccess extends Success { | ||
| final int progress; | ||
| final int chunkSize; |
nqhhdev
force-pushed
the
contact_sync_v2
branch
from
16177cb to
85c4b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.