Fixed AsyncServerInterceptor
to be compatible with OpenTelmetry
#5938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There was a bug in
AsyncServerInterceptor
where aForwardingServerCall
was not unwrapped properly via reflection. Because of that, OpenTelemetry'sTracingServerCall
that wraps the existingServerCall
usingForwardingServerCall
was rejected by the following condition.armeria/grpc/src/main/java/com/linecorp/armeria/server/grpc/DeferredListener.java
Lines 51 to 52 in 6dd5cd1
Modifications:
ForwardingServerCall.delegate()
.Result:
AsyncServerInterceptor
is incompatible with the OpenTelemetry gRPC agent.