docs: fix typo #523
Merged
docs: fix typo #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbl428
requested review from
pickmoment,
huisam,
cj848 and
shouwn
as code owners
말씀해주신 것처럼 it이 가르키는 것이 |
|
혹시 영문도 같이 수정해주실 수 있나요? |
|
네 영문도 수정했습니다! |
waahhh
reviewed
Nov 13, 2023
| @@ -40,7 +40,7 @@ bookRepository.findPage(pageable) { | |||
| ## Spring Batch | |||
|
|
|||
| SpringBatch는 JPQL로 쿼리를 할 수 있도록 `JpaPagingItemReader`와 `JpaCursorItemReader`를 제공합니다. | |||
| Kotlin JDSL은 DSL로 생성된 JPQL 쿼리가 JpqReader들에서 실행될 수 있도록 `KotlinJdslQueryProvider`을 제공합니다. | |||
| Kotlin JDSL은 DSL로 생성된 JPQL 쿼리가 위 ItemReader들에서 실행될 수 있도록 `KotlinJdslQueryProvider`을 제공합니다. | |||
There was a problem hiding this comment.
제 생각엔 KotlinJdslQueryProvider을 보단 KotlinJdslQueryProvider를 표현이 좀 더 자연스러운것 같아요!
추가로 동일 문서상의 Spring Boot AutoConfigure 파트에서 KotlinJdslAutoConfiguration를 보단 KotlinJdslAutoConfiguration을 표현이 자연스러운것 같아요~
There was a problem hiding this comment.
을 -> 를, 를 -> 을이군요. 말씀해주신 게 더 자연스럽네요. @jbl428 님 혹시 이 부분도 같이 수정해주실 수 있으신가요?
shouwn
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Kotlin JDSL provides KotlinJdslQueryProvider so that a JPQL query created in DSL can be executed on it.인데 마지막 it이 them 이 되어야 하는건지 확실하지 않네요Commit Convention Rule
commit typeplease describe it on the Pull Request