Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gihub action go matrix from 1.19 to 1.20.6 #351

Merged
merged 2 commits into from
Jul 31, 2023
Merged

update gihub action go matrix from 1.19 to 1.20.6 #351

merged 2 commits into from
Jul 31, 2023

Conversation

kkdai
Copy link
Member

@kkdai kkdai commented Jul 31, 2023

golang 1.18 was already EOL. time to go to the 1.19!
https://endoflife.date/go

@John-Lin
Copy link
Member

LGTM

tokuhirom
tokuhirom approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But we may need to use the golint alternative to keep code quality after merge this PR.

@kkdai kkdai mentioned this pull request Jul 31, 2023
Open
@kkdai
Copy link
Member Author

kkdai commented Jul 31, 2023 •
edited
Loading

ok, file another issue #352 to follow-up.

@kkdai kkdai merged commit f684564 into line:master Jul 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@tokuhirom tokuhirom tokuhirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkdai @John-Lin @tokuhirom