Inner join #603
Draft
Inner join #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draw inner join for almost all joins. The exception is when the join angle is tiny. It shouldn't be too hard to add optimizations, especially when it's possible to evaluate that the join is entirely inside one side of the stroke. It's under an #ifdef, the old code is not changed substantially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds inner joins. It's on top of a branch intended to benchmark arcs; the inner join commit disables that so the rendered results should be correct.
There's little optimization. A next step would be to evaluate when the join is inside the adjoining stroke, and draw a simpler version (two lines, from the old contour point to the center to the new) in that case.
This is mostly for the stroke expansion paper, but could be adapted to main.