Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the async pipeline from the public API #706

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 27, 2024

In doing ports to Vello 0.3 in our other repositories, I kept running into that adding the debug_layers field needed to be added, and I don't think it will be clear to users what it's for.

In addition, there is no reason to use the async pipeline for end users (at least as things stand). In #694, the debug layers feature was marked as internal, so that isn't a good reason.

@DJMcNab DJMcNab added this to the Vello 0.3 release milestone Sep 27, 2024
@DJMcNab DJMcNab added this pull request to the merge queue Oct 3, 2024
@DJMcNab DJMcNab removed this pull request from the merge queue due to a manual request Oct 3, 2024
@DJMcNab DJMcNab changed the title Remove the async pipeline from the public API Hide the async pipeline from the public API Oct 3, 2024
@DJMcNab DJMcNab added this pull request to the merge queue Oct 3, 2024
Merged via the queue into linebender:main with commit 88e59c3 Oct 3, 2024
17 checks passed
@DJMcNab DJMcNab deleted the async_less branch October 3, 2024 16:12
github-merge-queue bot pushed a commit that referenced this pull request Oct 4, 2024
Adds #706 and #711 to the changelog, as they are somewhat major changes.

I've not added #705, as it seemed to be a regression from 0.2.0 rather
than a relevant change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants