Make Scylla run in production mode #2603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos-h
force-pushed
the
scylla-docker-prod
branch
from
7da8793
to
38c7d5a
Compare
christos-h
force-pushed
the
scylla-docker-prod
branch
from
b272a8a
to
38c7d5a
Compare
|
nit: Reading the title of the PR, we don't know if the statement is true before or after the changes |
ma2bd
approved these changes
Oct 18, 2024
christos-h
changed the title
ma2bd
reviewed
Oct 21, 2024
Comment on lines
+50
to
+51
| - name: Update aio-max-nr | ||
| run: echo 1048576 > /proc/sys/fs/aio-max-nr |
There was a problem hiding this comment.
Yeah - this doesn't work on GH runners unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Scylla is running in developer mode causing performance issues and crashes for docker-compose deployment.
Proposal
Switch developer mode off. Also enable the
--overprovisionedflag so that Scylla doesn't hog all the host machine's resources.Test Plan
Tested manually. Logs show dev mode is off.
Release Plan
testnetbranch, then