Depend on other services based on health checks for docker compose #2715
+5
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
andresilva91
force-pushed
the
10-25-depend_on_other_services_based_on_health_checks_for_docker_compose
branch
from
4251b89
to
ddc8ee9
Compare
andresilva91
deleted the
10-25-depend_on_other_services_based_on_health_checks_for_docker_compose
branch
ma2bd
pushed a commit
that referenced
this pull request
Oct 25, 2024
…2715) ## Motivation When using Docker Compose, we're not currently properly waiting for the service dependencies. ## Proposal Add a health check, and remove the `init_done` file ## Test Plan CI: we can see from the Docker CI logs that both the `proxy` and `shard`s services only get created after `shard-init` exits: ``` Network docker_default Creating Network docker_default Created Volume "docker_grafana-storage" Creating Volume "docker_grafana-storage" Created Volume "docker_linera-scylla-data" Creating Volume "docker_linera-scylla-data" Created Container scylla Creating Container prometheus Creating Container grafana Creating Container prometheus Created Container scylla Created Container grafana Created Container shard-init Creating Container shard-init Created Container proxy Creating Container docker-shard-4 Creating Container docker-shard-2 Creating Container docker-shard-1 Creating Container docker-shard-3 Creating Container docker-shard-1 Created <---- Creations Container proxy Created <---- Container docker-shard-4 Created <---- Container docker-shard-3 Created <---- Container docker-shard-2 Created <---- Container grafana Starting Container prometheus Starting Container scylla Starting Container scylla Started Container grafana Started Container shard-init Starting Container prometheus Started Container shard-init Started Container shard-init Waiting Container shard-init Waiting Container shard-init Exited <---- Exits Container proxy Starting <---- Starts Container shard-init Exited Container docker-shard-4 Starting <---- Container proxy Started Container docker-shard-4 Started Container docker-shard-1 Starting <---- Container docker-shard-1 Started Container docker-shard-3 Starting <---- Container docker-shard-3 Started Container docker-shard-2 Starting <---- Container docker-shard-2 Started Container prometheus Waiting Container grafana Waiting Container scylla Waiting Container proxy Waiting Container docker-shard-4 Waiting Container docker-shard-1 Waiting Container docker-shard-3 Waiting Container docker-shard-2 Waiting Container shard-init Waiting Container docker-shard-4 Healthy Container docker-shard-1 Healthy Container docker-shard-3 Healthy Container docker-shard-2 Healthy Container proxy Healthy Container shard-init Exited Container scylla Healthy Container grafana Healthy Container prometheus Healthy ``` ## Release Plan - Nothing to do / These changes follow the usual release cycle.
ma2bd
pushed a commit
that referenced
this pull request
Oct 26, 2024
…2715) ## Motivation When using Docker Compose, we're not currently properly waiting for the service dependencies. ## Proposal Add a health check, and remove the `init_done` file ## Test Plan CI: we can see from the Docker CI logs that both the `proxy` and `shard`s services only get created after `shard-init` exits: ``` Network docker_default Creating Network docker_default Created Volume "docker_grafana-storage" Creating Volume "docker_grafana-storage" Created Volume "docker_linera-scylla-data" Creating Volume "docker_linera-scylla-data" Created Container scylla Creating Container prometheus Creating Container grafana Creating Container prometheus Created Container scylla Created Container grafana Created Container shard-init Creating Container shard-init Created Container proxy Creating Container docker-shard-4 Creating Container docker-shard-2 Creating Container docker-shard-1 Creating Container docker-shard-3 Creating Container docker-shard-1 Created <---- Creations Container proxy Created <---- Container docker-shard-4 Created <---- Container docker-shard-3 Created <---- Container docker-shard-2 Created <---- Container grafana Starting Container prometheus Starting Container scylla Starting Container scylla Started Container grafana Started Container shard-init Starting Container prometheus Started Container shard-init Started Container shard-init Waiting Container shard-init Waiting Container shard-init Exited <---- Exits Container proxy Starting <---- Starts Container shard-init Exited Container docker-shard-4 Starting <---- Container proxy Started Container docker-shard-4 Started Container docker-shard-1 Starting <---- Container docker-shard-1 Started Container docker-shard-3 Starting <---- Container docker-shard-3 Started Container docker-shard-2 Starting <---- Container docker-shard-2 Started Container prometheus Waiting Container grafana Waiting Container scylla Waiting Container proxy Waiting Container docker-shard-4 Waiting Container docker-shard-1 Waiting Container docker-shard-3 Waiting Container docker-shard-2 Waiting Container shard-init Waiting Container docker-shard-4 Healthy Container docker-shard-1 Healthy Container docker-shard-3 Healthy Container docker-shard-2 Healthy Container proxy Healthy Container shard-init Exited Container scylla Healthy Container grafana Healthy Container prometheus Healthy ``` ## Release Plan - Nothing to do / These changes follow the usual release cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using Docker Compose, we're not currently properly waiting for the service dependencies.
Proposal
Add a health check, and remove the
init_donefileTest Plan
CI: we can see from the Docker CI logs that both the
proxyandshards services only get created aftershard-initexits:Release Plan