Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory for creating Kvin instances based on RDF configurations #13

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

kenwenzel
Copy link
Member

This change adds the ability to configure different Kvin implementations via a factory pattern using RDF types and associated configuration properties.

Copy link

@mfriedemann mfriedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

However, Data.scala and KvinManager.java still use the old fhg plugin name:

val cfgURI = URIs.createURI("plugin://de.fraunhofer.iwu.linkedfactory.service/data/")

static final URI cfgUri = URIs.createURI("plugin://de.fraunhofer.iwu.linkedfactory.service/data/");

@kenwenzel
Copy link
Member Author

@mfriedemann I've fixed the namespaces and separated the configurations of default data model and the Kvin store.

@kenwenzel kenwenzel merged commit 886e2c7 into main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants