Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ignore_index tests #310

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add missing ignore_index tests #310

wants to merge 4 commits into from

Conversation

Tcc0403
Copy link
Contributor

@Tcc0403 Tcc0403 commented Oct 15, 2024 •
edited
Loading

Summary

ignore_index in fused_linear_cross_entropy was not tested

Testing Done

  • Hardware Type: gpu-ci
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@Tcc0403 Tcc0403 marked this pull request as ready for review October 15, 2024 23:09
ByronHsu
ByronHsu approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tcc0403 @ByronHsu