-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor chunked preference functions and distillation base class #491
base: main
Are you sure you want to change the base?
Conversation
beta (float): Weight for the CPO loss | ||
chosen_logps_chunk (torch.Tensor): Avg log probabilities of chosen tokens in the chunk. Shape: (batch_size,). | ||
rejected_logps_chunk (torch.Tensor): Avg log probabilities of rejected tokens in the chunk. Shape: (batch_size,). | ||
full_target (torch.Tensor): Non chunked full target tensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder is it full_target
or actually target_chunk
?
From the fused function, we are feeding into target_chunk
def fused_fwd_bwd(
input_chunk, target_chunk, ref_input_chunk, preference_labels_chunk
):
"""
Fused forward and backward pass for a chunk of input and target.
"""
if bias is not None:
return torch.func.grad_and_value(
compute_loss, argnums=(0, 1, 3), has_aux=True
)(
input_chunk,
weight,
target_chunk,
bias,
ref_input_chunk=ref_input_chunk,
preference_labels=preference_labels_chunk,
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like it should be the full target as we use it to normalize and then sum up for all chunks but seems we're feeding the target_chunk instead?
Summary
Remove redundant code by refactoring
Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence