Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 594]exposed the chunk loss in jsb_loss.py #598

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vulkomilev
Copy link

Summary

I have exposed the chunk loss as requested here #594

Testing Done

I have ran test/chunked_loss/test_jsd_loss.py but I couldn't finish it even with the original repo.

4090

Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.
-->

  • Hardware Type:
  • [ x] run make test to ensure correctness
  • [ x] run make checkstyle to ensure code style
  • [x ] run make test-convergence to ensure convergence

Copy link
Collaborator

@RichhLi RichhLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey great work. Sorry I didn't see this, I worked on the same issue. #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants