Recover from last log segment with invalid messages #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlin-linkedin
requested review from
snalli,
SophieGuo410 and
Arun-LinkedIn
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3018 +/- ##
============================================
+ Coverage 64.24% 69.95% +5.70%
- Complexity 10398 12205 +1807
============================================
Files 840 894 +54
Lines 71755 75615 +3860
Branches 8611 9035 +424
============================================
+ Hits 46099 52893 +6794
+ Misses 23004 19961 -3043
- Partials 2652 2761 +109 ☔ View full report in Codecov by Sentry. |
SophieGuo410
approved these changes
Mar 5, 2025
| */ | ||
| void truncateTo(long offset) throws IOException { | ||
| long currentFileSize = sizeInBytes(); | ||
| if (currentFileSize < offset) { |
There was a problem hiding this comment.
QQ: in which scenario this will happen?
There was a problem hiding this comment.
it should never happen, adding it here just for sanity check.
Arun-LinkedIn
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we don't ignore invalid log segment from this PR #2744, we run into lots of error replicas due to invalid messages in last log segment when power outage happens. This PR adds configuration and logic to deal with those errors.
When there are invalid messages in the log segment when persistent index is trying to recover index segment files, we check if the log segment is the last log segment and if the amount of remaining bytes are small, if so, we just ignore the invalid message and move on with the valid message.
Testing Done
Added unit tests.