Revise prefix requirement in list request #3022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssaxu333
force-pushed
the
prefixListRequest
branch
from
6c52d7a to
7db35b5
Compare
SophieGuo410
reviewed
Mar 6, 2025
| @@ -537,6 +537,7 @@ public static final class InternalKeys { | |||
| * Rest method for the rest request | |||
| */ | |||
| public static final String REST_METHOD = KEY_PREFIX + "rest-method"; | |||
There was a problem hiding this comment.
We don't need this REST_METHOD right? Can we remove it?
There was a problem hiding this comment.
Yep, I'll remove it.
| RequestPath requestPath = (RequestPath) restRequest.getArgs().get(REQUEST_PATH); | ||
| return restRequest.getRestMethod() == RestMethod.GET && restRequest.getArgs().containsKey(S3_REQUEST) | ||
| && NamedBlobPath.parse(requestPath, restRequest.getArgs()).getBlobName() == null; | ||
| && splitPath(requestPath.getOperationOrBlobId(true)).length == LIST_REQUEST_SEGMENTS; |
There was a problem hiding this comment.
QQ. Why changing this?
| @@ -97,7 +99,7 @@ public static NamedBlobPath parseS3(String path, Map<String, Object> args) throw | |||
| boolean isGetObjectLockRequest = args.containsKey(OBJECT_LOCK_PARAM); | |||
| // For s3 request, if splitPath.length = 3 && Method = GET, the expected segments = 3 | |||
| // All other requests require segments = 4 | |||
| boolean isListObjectRequest = RestUtils.isListObjectRequest(path, args); | |||
| boolean isListObjectRequest = args.containsKey(LIST_REQUEST); | |||
| int expectedSegments = (isListObjectRequest || isGetObjectLockRequest) ? 3 : 4; | |||
| if (splitPath.length != expectedSegments || !Operations.NAMED_BLOB.equalsIgnoreCase(splitPath[0])) { | |||
| throw new RestServiceException(String.format( | |||
There was a problem hiding this comment.
Hmm.. isListObjectRequest is true if number of segments is 3. And then, if isListObjectRequest is true, expected segments = 3. Wondering if this is equivalent to checking if splitPath.length == 3 or splitPath.length == 4.
It means GET /s3/account-name/container-name is treated as LIST request? + @justinlin-linkedin also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the list request check and processing from NamedBlobPath to S3GetHandler.
Testing Done
Local test and unit test.