Coral-Schema: return nullable schema for array item and map value (#345)

linkedin · Jan 17, 2023 · fda6891 · fda6891
1 parent d720898
commit fda6891
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/coral-schema/src/main/java/com/linkedin/coral/schema/avro/ToNullableSchemaVisitor.java b/coral-schema/src/main/java/com/linkedin/coral/schema/avro/ToNullableSchemaVisitor.java
@@ -46,12 +46,12 @@ public Schema union(Schema union, List<Schema> options) {
 
   @Override
   public Schema array(Schema array, Schema element) {
-    return Schema.createArray(element);
+    return Schema.createArray(SchemaUtilities.makeNullable(element, false));
   }
 
   @Override
   public Schema map(Schema map, Schema value) {
-    return Schema.createMap(value);
+    return Schema.createMap(SchemaUtilities.makeNullable(value, false));
   }
 
   @Override

diff --git a/coral-schema/src/test/resources/testToNullableSchema-expected.avsc b/coral-schema/src/test/resources/testToNullableSchema-expected.avsc
@@ -18,14 +18,14 @@
     "name" : "Array_Col",
     "type" : [ "null", {
       "type" : "array",
-      "items" : "string"
+      "items" : [ "null", "string" ]
     } ],
     "default" : null
   }, {
     "name" : "Map_Col",
     "type" : [ "null", {
       "type" : "map",
-      "values" : "string"
+      "values" : [ "null", "string" ]
     } ],
     "default" : null
   }, {
@@ -86,7 +86,7 @@
         "name" : "Map_Col",
         "type" : [ "null", {
           "type" : "map",
-          "values" : "string"
+          "values" : [ "null", "string" ]
         } ],
         "default" : null
       } ]