Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump all dependenciess with vulnerabilities #2141

Closed
wants to merge 3 commits into from
Closed

bump all dependenciess with vulnerabilities #2141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f463a6c
bump all deps with vulnerabilities
slaupster Apr 1, 2024
7f54b35
Merge branch 'main' into bump-deps
slaupster Aug 6, 2024
9650717
Merge branch 'main' into bump-deps
slaupster Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ project(':cruise-control') {
implementation 'com.google.code.gson:gson:2.9.0'
implementation "org.eclipse.jetty:jetty-server:${jettyVersion}"
implementation 'io.dropwizard.metrics:metrics-jmx:4.2.9'
implementation 'com.nimbusds:nimbus-jose-jwt:9.24'
implementation 'com.nimbusds:nimbus-jose-jwt:9.37.3'
implementation 'io.swagger.parser.v3:swagger-parser-v3:2.1.16'
implementation 'io.github.classgraph:classgraph:4.8.141'
implementation 'com.google.code.findbugs:jsr305:3.0.2'
Expand All @@ -301,7 +301,7 @@ project(':cruise-control') {
api 'io.swagger.core.v3:swagger-core:2.0.2'
api 'com.google.guava:guava:32.1.3-jre'
api 'org.json:json:20231013'
api 'org.xerial.snappy:snappy-java:1.1.10.1'
api 'org.xerial.snappy:snappy-java:1.1.10.5'

testImplementation project(path: ':cruise-control-metrics-reporter', configuration: 'testOutput')
testImplementation project(path: ':cruise-control-core', configuration: 'testOutput')
Expand Down
8 changes: 4 additions & 4 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ org.gradle.parallel=false
org.gradle.jvmargs=-Xms512m -Xmx512m
scalaVersion=2.13.10
kafkaVersion=3.5.1
zookeeperVersion=3.8.3
nettyVersion=4.1.100.Final
jettyVersion=9.4.53.v20231009
vertxVersion=4.5.0
zookeeperVersion=3.8.4
nettyVersion=4.1.108.Final
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vertx uses 4.1.110 and most of the cases the actually used netty lib version will be that. Would it make sense to upgrade to 4.1.110.Final?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, especially if a major dependency like Vert.x already uses that version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is 4.1.114.Final which doesn't seem to have any CVE

jettyVersion=9.4.54.v20240208
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a newer version for jetty, 9.4.54 has a medium one: https://nvd.nist.gov/vuln/detail/CVE-2024-8184
9.4.56.v20240826

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving to 9.4.56.v20240826 should be safe

vertxVersion=4.5.7