-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#2039] Support default value semantic for AVRO (#75)
(cherry picked from commit c18f4c4)
- Loading branch information
Shenoda Guirguis
authored
Jun 21, 2021
1 parent
75c87e2
commit 78a8c43
Showing
16 changed files
with
1,138 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
api/src/test/java/org/apache/iceberg/types/TestDefaultValuesForContainerTypes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.iceberg.types; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import org.junit.Assert; | ||
import org.junit.BeforeClass; | ||
import org.junit.Test; | ||
|
||
import static org.apache.iceberg.types.Types.NestedField; | ||
import static org.apache.iceberg.types.Types.StructType; | ||
|
||
public class TestDefaultValuesForContainerTypes { | ||
|
||
static NestedField intFieldType; | ||
static NestedField stringFieldType; | ||
static StructType structType; | ||
|
||
@BeforeClass | ||
public static void beforeClass() { | ||
intFieldType = NestedField.optional(0, "optionalIntField", Types.IntegerType.get()); | ||
stringFieldType = NestedField.required(1, "requiredStringField", Types.StringType.get()); | ||
structType = StructType.of(Arrays.asList(intFieldType, stringFieldType)); | ||
} | ||
|
||
@Test | ||
public void testStructTypeDefault() { | ||
Map<String, Object> structDefaultvalue = new HashMap<>(); | ||
structDefaultvalue.put(intFieldType.name(), Integer.valueOf(1)); | ||
structDefaultvalue.put(stringFieldType.name(), "two"); | ||
NestedField structField = NestedField.optional(2, "optionalStructField", structType, structDefaultvalue, "doc"); | ||
Assert.assertTrue(structField.hasDefaultValue()); | ||
Assert.assertEquals(structDefaultvalue, structField.getDefaultValue()); | ||
} | ||
|
||
@Test (expected = IllegalArgumentException.class) | ||
public void testStructTypeDefaultInvalidFieldsTypes() { | ||
List<Object> structDefaultvalue = new ArrayList<>(); | ||
structDefaultvalue.add("one"); | ||
structDefaultvalue.add("two"); | ||
NestedField.optional(2, "optionalStructField", structType, structDefaultvalue, "doc"); | ||
} | ||
|
||
@Test (expected = IllegalArgumentException.class) | ||
public void testStructTypeDefaultInvalidNumberFields() { | ||
List<Object> structDefaultvalue = new ArrayList<>(); | ||
structDefaultvalue.add(Integer.valueOf(1)); | ||
structDefaultvalue.add("two"); | ||
structDefaultvalue.add("three"); | ||
NestedField.optional(2, "optionalStructField", structType, structDefaultvalue, "doc"); | ||
} | ||
} |
82 changes: 82 additions & 0 deletions
82
api/src/test/java/org/apache/iceberg/types/TestNestedFieldDefaultValues.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.iceberg.types; | ||
|
||
import org.apache.iceberg.types.Types.NestedField; | ||
import org.junit.Assert; | ||
import org.junit.Test; | ||
|
||
import static org.apache.iceberg.types.Types.NestedField.optional; | ||
import static org.apache.iceberg.types.Types.NestedField.required; | ||
|
||
|
||
public class TestNestedFieldDefaultValues { | ||
|
||
private final int id = 1; | ||
private final String fieldName = "fieldName"; | ||
private final Type fieldType = Types.IntegerType.get(); | ||
private final String doc = "field doc"; | ||
private final Integer defaultValue = 100; | ||
|
||
@Test | ||
public void testConstructorsValidCases() { | ||
// optional constructors | ||
Assert.assertFalse(optional(id, fieldName, fieldType).hasDefaultValue()); | ||
Assert.assertFalse(optional(id, fieldName, fieldType, doc).hasDefaultValue()); | ||
NestedField nestedFieldWithDefault = optional(id, fieldName, fieldType, defaultValue, doc); | ||
Assert.assertTrue(nestedFieldWithDefault.hasDefaultValue()); | ||
Assert.assertEquals(defaultValue, nestedFieldWithDefault.getDefaultValue()); | ||
nestedFieldWithDefault = optional(id, fieldName, fieldType, defaultValue, null); | ||
Assert.assertTrue(nestedFieldWithDefault.hasDefaultValue()); | ||
Assert.assertEquals(defaultValue, nestedFieldWithDefault.getDefaultValue()); | ||
|
||
// required constructors | ||
Assert.assertFalse(required(id, fieldName, fieldType).hasDefaultValue()); | ||
Assert.assertFalse(required(id, fieldName, fieldType, doc).hasDefaultValue()); | ||
Assert.assertFalse(required(id, fieldName, fieldType, null, doc).hasDefaultValue()); | ||
nestedFieldWithDefault = required(id, fieldName, fieldType, defaultValue, doc); | ||
Assert.assertTrue(nestedFieldWithDefault.hasDefaultValue()); | ||
Assert.assertEquals(defaultValue, nestedFieldWithDefault.getDefaultValue()); | ||
nestedFieldWithDefault = required(id, fieldName, fieldType, defaultValue, null); | ||
Assert.assertTrue(nestedFieldWithDefault.hasDefaultValue()); | ||
Assert.assertEquals(defaultValue, nestedFieldWithDefault.getDefaultValue()); | ||
|
||
// of constructors | ||
Assert.assertFalse(NestedField.of(id, true, fieldName, fieldType).hasDefaultValue()); | ||
Assert.assertFalse(NestedField.of(id, true, fieldName, fieldType, doc).hasDefaultValue()); | ||
nestedFieldWithDefault = NestedField.of(id, true, fieldName, fieldType, defaultValue, doc); | ||
Assert.assertTrue(nestedFieldWithDefault.hasDefaultValue()); | ||
Assert.assertEquals(defaultValue, nestedFieldWithDefault.getDefaultValue()); | ||
} | ||
|
||
@Test (expected = IllegalArgumentException.class) | ||
public void testOptionalWithInvalidDefaultValueClass() { | ||
// class of default value does not match class of type | ||
Long wrongClassDefaultValue = 100L; | ||
optional(id, fieldName, fieldType, wrongClassDefaultValue, doc); | ||
} | ||
|
||
@Test (expected = IllegalArgumentException.class) | ||
public void testReqiredWithInvalidDefaultValueClass() { | ||
// class of default value does not match class of type | ||
Long wrongClassDefaultValue = 100L; | ||
required(id, fieldName, fieldType, wrongClassDefaultValue, doc); | ||
} | ||
} |
Oops, something went wrong.