Unpin funowl and fix bug in test example. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compliance test had a data bug where a linkml class intended as anonymous was being mapped to an owl Class declaration, rather than anon expression. This bug was masked (harmlessly) in previous versions of funowl, but in newer versions it attempted to write a declaration with null uri and raised error. Fixed example to have the right declaration; also made the dumper code more defensive, and throw more meaningful error in case of declarations that can't be fulfilled. Fixes #32 This PR also unpins the previously defensive pinning of funowl, allowing funowl 0.2.x and thus newer versions of rdflib, replaces/fixes #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compliance test had a data bug where a linkml class intended as
anonymous was being mapped to an owl Class declaration, rather than
anon expression.
This bug was masked (harmlessly) in previous versions of funowl,
but in newer versions it attempted to write a declaration with null
uri and raised error.
Fixed example to have the right declaration; also made the dumper
code more defensive, and throw more meaningful error in case of
declarations that can't be fulfilled.
Fixes #32
This PR also unpins the previously defensive pinning of funowl,
allowing funowl 0.2.x and thus newer versions of rdflib,
replaces/fixes #37