Adds SHACL ifabsent handling for type uriorcurie
#2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsheunis
force-pushed
the
shacl-ifabsent-uriorcurie
branch
from
a1fee40 to
0447d19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 120 120
Lines 13398 13400 +2
Branches 3768 3768
=======================================
+ Hits 10889 10891 +2
Misses 1892 1892
Partials 617 617 ☔ View full report in Codecov by Sentry. |
| + """ | ||
| - name: definition_A | ||
| range: uriorcurie | ||
| ifabsent: string(https://en.wikipedia.org/wiki/Student) |
There was a problem hiding this comment.
I'm wondering if this should be string(..) or uriorcurie(..) or uri(..) 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the raising of
NotImplementedErrorforifabsenthandling of typeuriorcurieduring shacl generation with two lines of code. The relevant test is also updated.Closes #2502