-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] : add support for configuring nodebalancers with VPC #337
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 71.77% 71.82% +0.05%
==========================================
Files 14 14
Lines 2384 2435 +51
==========================================
+ Hits 1711 1749 +38
- Misses 515 525 +10
- Partials 158 161 +3 ☔ View full report in Codecov by Sentry. |
5230187
to
a775723
Compare
a775723
to
bf00864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bf00864
to
7d4b6b3
Compare
General:
This PR allows nodebalancer backends to be configured directly with VPC if specific annotations are added to the service.
Pull Request Guidelines: