Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : add support for configuring nodebalancers with VPC #337

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Feb 26, 2025

General:

This PR allows nodebalancer backends to be configured directly with VPC if specific annotations are added to the service.

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the new-feature for new features in the changelog. label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 78.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (b56ba08) to head (7d4b6b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/loadbalancers.go 78.33% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   71.77%   71.82%   +0.05%     
==========================================
  Files          14       14              
  Lines        2384     2435      +51     
==========================================
+ Hits         1711     1749      +38     
- Misses        515      525      +10     
- Partials      158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait changed the title [WIP][feat] : add support for configuring nodebalancers with VPC [feat] : add support for configuring nodebalancers with VPC Feb 27, 2025
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulait rahulait merged commit dcaae71 into main Mar 3, 2025
9 checks passed
@rahulait rahulait deleted the nb-vpc-support-2 branch March 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants