Simplify health check to ignore response #258
Merged
+14
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Previously, the health check was a HTTP Get request to the
hostBase
address - however this equates to aListBuckets
S3 call on RGW. As such, a situation can arise where the request may not be authorized, resulting in a 403 error. This makes checking the response or response code a bit redundant.Instead, this PR simplifies the health check to simply establish a connection with the
hostBase
address - if an error occurs or a connection cannot be made, then the health check will be deemed a failure, otherwise it is considered successful and the backend is marked as healthy.I have:
make reviewable
to ensure this PR is ready for review.make ceph-chainsaw
to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.md
for information on how to run tests against a Ceph cluster.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
make chainsaw
andmake ceph-chainsaw
both passing.