Return error for unhealthy backend discovery during subresrource observeBackend calls #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When we
Observe
a subresource client, we skip over any unhealthy backends. We do this so as not to block subsequentCreate/Update/Delete
calls after observation.However, during
Update
we also perform this check/skip as part of lower levelobserveBackend
function calls - this can result inUpdate
silently failing to reconcile a subresource on a backend due to a momentarily unhealthy state.As such, the check for the backend's healthiness has been split for each subresource client:
Observe
phase, unhealthy backends are simply skipped to allow subsequent operations to continue.Update
phase (which also callsobserveBackend
for each subresource client at a lower level), unhealthy backends result in an error and a re-queue of the request - doing this is safe due to the exponential back-off mechanism.I have:
make reviewable
to ensure this PR is ready for review.make ceph-chainsaw
to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.md
for information on how to run tests against a Ceph cluster.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Existing tests - this change fixes a very specific edge case which is difficult to reproduce.