-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test action woke.yml. [citest skip] #307
Conversation
[citest skip] |
[citest skip] |
2 similar comments
[citest skip] |
[citest skip] |
9b21826
to
15434ac
Compare
@spetrosi, @richm, I'm testing Here are the details. In
But the action itself fails as follows:
I also tried disabling
Then, the action passes even if any real error is reported... (;_;) |
@nhosoi not sure - can you make it work if you run it locally? You may have to dig into the source code to figure out what it is doing. Or file an issue in the woke github - the authors are pretty responsive. |
Never mind... Basically, running Yes, I got the same result set in my local running. If I set INPUT_FAIL_ON_ERROR to true, it reports an error regardless of the severity.
If I unset INPUT_FAIL_ON_ERROR, woke does not report an error, even if a real error is found.
All right. Let me take a look... |
@richm, @spetrosi, could you please take a look at get-woke/woke#252? |
lgtm |
Thank you, @richm. This PR 307 depends upon these PRs. Without get-woke/woke#252 or its replacement, this woke action fails by the existence of the word And once linux-system-roles/tox-lsr#97 is merged, the following URL needs to be replaced with the official one. |
d16ce41
to
af3888b
Compare
.github/workflows/woke.yml
Outdated
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/checkout@v2 | |
uses: actions/checkout@v3 |
.github/workflows/woke.yml
Outdated
@@ -0,0 +1,18 @@ | |||
# yamllint disable rule:line-length | |||
# name: woke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# name: woke | |
name: woke |
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml Apply "wokeignore:rule=<word>" to the non-inclusive words.
Closing this pr in favor of #310. |
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
Apply "wokeignore:rule=" to the non-inclusive words.