Skip to content

Commit

Permalink
Version 1.3.0 - append to CHANGELOG.md [citest skip] (#168)
Browse files Browse the repository at this point in the history
[1.3.0] - 2023-01-31
--------------------

- Rename mssql_ha_listener_port to mssql_ha_endpoint_port (#166)
  As per feedback from Microsoft, mssql_ha_listener_port should be called
  mssql_ha_endpoint_port, as that port is used
  when creating endpoint for replication between primary and secondary
  replica. Listener is a term used for AG listener associated with AG
  which is used to route client connection to primary replica (or read
  only secondary replica based on configuration and request type).
  And listener uses tcp_port, hence the confusion.

- Restructure README files to split it into available scenarios (#161)

- Add AD integration functionality (#159)
  - Add mssql version to set up
  - Add clean up for realm to clean_up_mssql.yml
  - Remove setting passwords with environment:
    Set password inline for security because setting passwords with
    environment: reveals the value when running playbooks with high
    verbosity
  - Add collection-requirements.yml
  - Set the mssql_password variable to default null after test verification

- Add a note about not supporting direct upgrade 2017>2022 (#157)

- ansible-lint 6.x fixes (#162)
  The big one is that ansible-lint doesn't like templates in `name`
  strings except at the end.  In general, Ansible does not like having
  templated variables in `name` values because it makes it harder to
  grep the source to find a log message in the source.
  The other ones are jinja spacing cleanup, use of `true`/`false`
  instead of `yes`/`no`, and various other cleanup.

- Add check for non-inclusive language (#158)
  - Cleanup non-inclusive words.
  - Add a check for usage of terms and language that is considered
    non-inclusive. We are using the woke tool for this with a wordlist
    that can be found at
    https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
  - Create separate github actions for various checks; get rid of monolithic tox.yml
    Using separate github actions, and especially the official github actions which
    generally have support for in-line comments, should help greatly with
    readability and troubleshooting test results.
  - skip no-changelog errors because it searches changelog in .collection
    galaxy[no-changelog]: No changelog found. Please add a changelog file.
    Refer to the galaxy.md file for more info.
    .collection/galaxy.yml:1

Signed-off-by: Sergei Petrosian <[email protected]>
  • Loading branch information
spetrosi authored Jan 31, 2023
1 parent d8bfcc9 commit 90a86a5
Showing 1 changed file with 48 additions and 1 deletion.
49 changes: 48 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
Changelog
=========

[1.3.0] - 2022-12-21
[1.3.0] - 2023-01-31
--------------------

### New Features

- Add support for SQL Server 2022 (#148)
Expand Down Expand Up @@ -38,6 +39,27 @@ Changelog
- Add support for read-scale always on clusters
- Improve tmp file names and logging for sqlcmd_input_file
- Add __mssql_single_node_test as a workaround for single-node tests

- Rename mssql_ha_listener_port to mssql_ha_endpoint_port (#166)
As per feedback from Microsoft, mssql_ha_listener_port should be called
mssql_ha_endpoint_port, as that port is used
when creating endpoint for replication between primary and secondary
replica. Listener is a term used for AG listener associated with AG
which is used to route client connection to primary replica (or read
only secondary replica based on configuration and request type).
And listener uses tcp_port, hence the confusion.

- Restructure README files to split it into available scenarios (#161)

- Add AD integration functionality (#159)
- Add mssql version to set up
- Add clean up for realm to clean_up_mssql.yml
- Remove setting passwords with environment:
Set password inline for security because setting passwords with
environment: reveals the value when running playbooks with high
verbosity
- Add collection-requirements.yml
- Set the mssql_password variable to default null after test verification

### Bug Fixes

Expand Down Expand Up @@ -68,6 +90,8 @@ Changelog
- Set __mssql_single_node_test to be false when not set (#143)
Remove redundant empty line in weekly CI job

- Add a note about not supporting direct upgrade 2017>2022 (#157)

### Other Changes

- weekly-ci: do not create a new PR every time
Expand Down Expand Up @@ -128,6 +152,29 @@ Changelog

- Use `docker` for ansible-test if not already doing that

- ansible-lint 6.x fixes (#162)
The big one is that ansible-lint doesn't like templates in `name`
strings except at the end. In general, Ansible does not like having
templated variables in `name` values because it makes it harder to
grep the source to find a log message in the source.
The other ones are jinja spacing cleanup, use of `true`/`false`
instead of `yes`/`no`, and various other cleanup.

- Add check for non-inclusive language (#158)
- Cleanup non-inclusive words.
- Add a check for usage of terms and language that is considered
non-inclusive. We are using the woke tool for this with a wordlist
that can be found at
https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
- Create separate github actions for various checks; get rid of monolithic tox.yml
Using separate github actions, and especially the official github actions which
generally have support for in-line comments, should help greatly with
readability and troubleshooting test results.
- skip no-changelog errors because it searches changelog in .collection
galaxy[no-changelog]: No changelog found. Please add a changelog file.
Refer to the galaxy.md file for more info.
.collection/galaxy.yml:1

[1.2.4] - 2022-09-01
--------------------

Expand Down

0 comments on commit 90a86a5

Please sign in to comment.