tests: factorize & fix URL for candlepin owner #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
|
[citest bad] |
richm
approved these changes
Aug 1, 2024
|
[citest bad] |
2 similar comments
|
[citest bad] |
|
[citest bad] |
|
[citest_bad] |
|
[citest] |
The Candlepin URL used to query the owner (= organization) used in the tests when using the self-deployed Candlepin was wrong, using the username rather than the organization name. It works fine because the username and the organization name are currently the same. Hence, to avoid issues in the future, properly use the organization name instead. To simplify the maintenance of that code, create a new helper fact with the Candlepin URL for the current owner. There is no behaviour change in the tests. Signed-off-by: Pino Toscano <[email protected]>
ptoscano
force-pushed
the
tests-candlepin-owner-url
branch
from
373e32a
to
cadc721
Compare
|
[citest] |
|
[citest_bad] |
|
I think we should go ahead and merge this PR. The failures are due to known issues not related to this PR, and we have a plan to address them. |
OK. I simply want to avoid forgetting about the issues, and then CI jobs keeps becoming more and more red :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Candlepin URL used to query the owner (= organization) used in the tests when using the self-deployed Candlepin was wrong, using the username rather than the organization name. It works fine because the username and the organization name are currently the same.
Hence, to avoid issues in the future, properly use the organization name instead. To simplify the maintenance of that code, create a new helper fact with the Candlepin URL for the current owner.
There is no behaviour change in the tests.