-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop usage of "auto_attach" of the "redhat_subscription" module #189
Conversation
[citest] |
[citest bad] |
Won't this break EL 7, 8, 9? |
Please rebase |
Nope; SCA works fine in those versions. |
2c914c1
to
20541a0
Compare
[citest] |
hmmm
I guess I need to tweak the test data - will need to tweak the test setup a bit. |
ok - but it is not related to this PR |
True, however the result is that the tests are broken :/ I should have hopefully fixed my candlepin-unofficial container image, and local changes to switch the testing account seems to work fine. I'll need #191 to fix one issue in the test setup, and then I can switch the account to a SCA one. |
"auto_attach" is supposed to automatically attach subscriptions for accounts in entitlement mode. in Simple Content Access mode, this option becomes a no-op in subscription-manager. The usage of this option was originally added to help testing regardless of the content access mode, even if the role supports only SCA. Since the entitlement mode has been officially deprecated for a couple of years already, and it is going away soon, then stop using the "auto_attach" option of the "redhat_subscription" module. There is no behaviour change. Signed-off-by: Pino Toscano <[email protected]>
20541a0
to
182218b
Compare
[citest] |
Now it should be fine :-) |
auto_attach
is supposed to automatically attach subscriptions for accounts in entitlement mode. in Simple Content Access mode, this option becomes a no-op in subscription-manager.The usage of this option was originally added to help testing regardless of the content access mode, even if the role supports only SCA. Since the entitlement mode has been officially deprecated for a couple of years already, and it is going away soon, then stop using the
auto_attach
option of theredhat_subscription
module.There is no behaviour change.