Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop usage of "auto_attach" of the "redhat_subscription" module #189

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ptoscano
Copy link
Collaborator

auto_attach is supposed to automatically attach subscriptions for accounts in entitlement mode. in Simple Content Access mode, this option becomes a no-op in subscription-manager.

The usage of this option was originally added to help testing regardless of the content access mode, even if the role supports only SCA. Since the entitlement mode has been officially deprecated for a couple of years already, and it is going away soon, then stop using the auto_attach option of the redhat_subscription module.

There is no behaviour change.

@ptoscano ptoscano requested a review from richm as a code owner July 30, 2024 13:25
@ptoscano
Copy link
Collaborator Author

[citest]

@ptoscano
Copy link
Collaborator Author

[citest bad]

@spetrosi
Copy link
Contributor

Won't this break EL 7, 8, 9?

@spetrosi
Copy link
Contributor

Please rebase

@ptoscano
Copy link
Collaborator Author

Won't this break EL 7, 8, 9?

Nope; SCA works fine in those versions.

@ptoscano
Copy link
Collaborator Author

[citest]

@ptoscano
Copy link
Collaborator Author

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

@richm
Copy link
Contributor

richm commented Jul 30, 2024

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

ok - but it is not related to this PR

@ptoscano
Copy link
Collaborator Author

ptoscano commented Aug 1, 2024

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

ok - but it is not related to this PR

True, however the result is that the tests are broken :/

I should have hopefully fixed my candlepin-unofficial container image, and local changes to switch the testing account seems to work fine.

I'll need #191 to fix one issue in the test setup, and then I can switch the account to a SCA one.

@ptoscano
Copy link
Collaborator Author

ptoscano commented Aug 5, 2024

I'll need #191 to fix one issue in the test setup, and then I can switch the account to a SCA one.

... which is #195, hopefully.

"auto_attach" is supposed to automatically attach subscriptions for
accounts in entitlement mode. in Simple Content Access mode, this option
becomes a no-op in subscription-manager.

The usage of this option was originally added to help testing regardless
of the content access mode, even if the role supports only SCA. Since
the entitlement mode has been officially deprecated for a couple of
years already, and it is going away soon, then stop using the
"auto_attach" option of the "redhat_subscription" module.

There is no behaviour change.

Signed-off-by: Pino Toscano <[email protected]>
@ptoscano
Copy link
Collaborator Author

ptoscano commented Aug 7, 2024

[citest]

@ptoscano
Copy link
Collaborator Author

ptoscano commented Aug 7, 2024

Now it should be fine :-)

@ptoscano ptoscano merged commit 9576e8a into linux-system-roles:main Aug 7, 2024
22 of 24 checks passed
@ptoscano ptoscano deleted the drop-auto_attach branch August 7, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants