tests: start candlepin container as privileged on EL 7 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be needed in EL 7; it should not be a problem, since the tests are usually run on an isolated system. Ensure to have the right distro facts for the needed check. Signed-off-by: Pino Toscano <[email protected]>
|
[citest] |
1 similar comment
|
[citest] |
|
ok - but note that ci tests will not run on el7 because "7" is not listed as a supported platform at https://github.com/linux-system-roles/rhc/blob/main/meta/main.yml#L13 |
Yes, that is fine - the actual enablement will come after this. I sent this because it was already a known bit I needed to change for it; in the meanwhile I tested whether there was anything else needed, and so far it seems not. |
richm
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be needed in EL 7; it should not be a problem, since the tests are usually run on an isolated system.
Ensure to have the right distro facts for the needed check.