Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dasharo flashrom: remove dummy and mtd for x86, put ast1100 as optional #1420

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

dasharo flashrom: remove dummy and mtd for x86, put ast1100 as optional #1420

wants to merge 4 commits into from

Commits on Jun 23, 2023

  1. flashrom now points to dasharo/flashrom master at Dasharo/flashrom@51… 

    …11246 from work under  https://github.com/Dasharo/flashrom/tree/kgpe-patch-rebase

Pointing to Dasharo/flashrom#11 so that CircleCI shows success where work is happening

Changes:
- "WARNERROR=no" is a env variable interpreted at compilation now, not a configuration option anymore
- ~To work around heads pkg-config, newer flashrom needs to have LIBS_BASE overriden to detect proper libusb and libpci as installed under heads/install~ fixed upstream in previous commits
- INSTALL="$(INSTALL)" DESTDIR="$(INSTALL)" CFLAGS="-I$(INSTALL)/include/libusb-1.0 -I$(INSTALL)/include/pci" and LDFLAGS="-L$(INSTALL)/lib" needs to be passed as env variable  to build properly
- flashrom module now depends on libusb, since flashrom looks for pkg-config of installed libusb as prereq
- flashrom ppc64: remove ast2400 and dummy, leaving NOTHING+MTD only

NOTES:
- newer flashrom version seems to need to have environment variables defined prior of make call on console, not passing options at make call
- CONFIG_INTERNAL is not enough to have internal programmer anymore on x86. CONFIG_INTERNAL_X86 also needs to be requested.

Collaboration happened under Dasharo/flashrom#11
    @tlaurion
    tlaurion committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    33551c8 View commit details
    Browse the repository at this point in the history

  2. modules/flashrom: passing optimization for size (-Os)

    @tlaurion
    tlaurion committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    dc12f47 View commit details
    Browse the repository at this point in the history

  3. flashrom: remove dummy, mtd and ast1100 on default builds to x86. 

    ast1100 can now be added per board config settings.

NExt commit does that for kgpe-d16
    @tlaurion
    tlaurion committed Jun 23, 2023
    1 Configuration menu
    Copy the full SHA
    0bcafbf View commit details
    Browse the repository at this point in the history

  4. kgpe-d16 boards: add CONFIG_FLASHROM_AST1100 as config option

    @tlaurion
    tlaurion committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e90d70b View commit details
    Browse the repository at this point in the history