Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x230t : add hotp/non-hotp variant and specialized coreboot config, add x230t to BOARD_TESTERS.md #1791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Sep 11, 2024

Might close #1744


  • x230t do not suffer from backspace and pipe keyboard issues since coreboot 24.02.01 + current 5.10.5 kernel used in master
  • x230t soundcard doesn't work
  • power button doesn't work

If this PR fixes x230t issues preventing x230t to be used by flashing x230 roms, cool.

Otherwise forget about x230t or deal with upstream coreboot and never talk about x230t or keyboard issues on old Thinpads tablet models until fixed upstream. Wil I do the same for x220t and other tablets? No. The trail below should suffice to any non-developer to create board variants. It's not coding, its porting: this is about plugging things together, not even understanding how things work under the hood. Nonetheless to say: more testers are needed for such boards in case something technical needs to be investigated: I won't have the time to do it if it doesn't work.

For more details, see all linked issues to #1744

Repro for anyone wanting to create a specialized board config pointing to a specialized coreboot/linux config file for a board variant. x230t is x230 but pointing to a different coreboot config file. This is all that is different, se file changes of this PR:

#do branch for commit
git checkout -b x230t_addition
#copy/move x230 boards and rename to x230t
cp -r boards/x230-maximized/ boards/x230t-maximized cp -r boards/x230-hotp-maximized boards/x230t-hotp-maximized mv boards/x230t-hotp-maximized/x230-hotp-maximized.config boards/x230t-hotp-maximized/x230t-hotp-maximized.config mv boards/x230t-maximized/x230-maximized.config boards/x230t-maximized/x230t-maximized.config cp config/coreboot-x230-maximized.config config/coreboot-x230t-maximized.config vim boards/x230t-maximized/x230t-maximized.config
#point boards to x230t to be modified coreboot config file
vim boards/x230t-hotp-maximized/x230t-hotp-maximized.config 
# call Heads coreboot Makefile helper to modify coreboot config with menuconfig in place
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=x230t-maximized coreboot.modify_and_save_oldconfig_in_place 
#Add board configs and coreboot config changes in to be git commit
git add boards/x230t-hotp-maximized/x230t-hotp-maximized.config boards/x230t-maximized/x230t-maximized.config config/coreboot-x230t-maximized.config 
#add x230t board names to be built by CircleCI by this commit
vim .circleci/config.yml
git add .circleci/config.yml
#Add @fhvyhjriur to x230t board testers in tracking file
vim BOARD_TESTERS.md
git add BOARD_TESTERS.md
#create git commit, signing commit with message
git commit --signoff -m
#push this commit to a PR.
git push --force tlaurion-github

@fhvyhjriur please test and report...

…d x230t to BOARD_TESTERS.md

Repro
git checkout -b x230t_addition
cp -r boards/x230-maximized/ boards/x230t-maximized
cp -r boards/x230-hotp-maximized boards/x230t-hotp-maximized
mv boards/x230t-hotp-maximized/x230-hotp-maximized.config boards/x230t-hotp-maximized/x230t-hotp-maximized.config
mv boards/x230t-maximized/x230-maximized.config boards/x230t-maximized/x230t-maximized.config
cp config/coreboot-x230-maximized.config config/coreboot-x230t-maximized.config
vim boards/x230t-maximized/x230t-maximized.config
vim boards/x230t-hotp-maximized/x230t-hotp-maximized.config
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=x230t-maximized coreboot.modify_and_save_oldconfig_in_place
meld config/coreboot-x230t-maximized.config config/coreboot-x230-maximized.config
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=x230t-maximized coreboot.save_in_defconfig_format_in_place
meld config/coreboot-x230t-maximized.config config/coreboot-x230-maximized.config
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=x230t-maximized coreboot.modify_and_save_oldconfig_in_place
git add boards/x230t-hotp-maximized/x230t-hotp-maximized.config boards/x230t-maximized/x230t-maximized.config config/coreboot-x230t-maximized.config
vim .circleci/config.yml
git add .circleci/config.yml
vim BOARD_TESTERS.md
git add BOARD_TESTERS.md
git commit --signoff -m
git push --force tlaurion-github

Signed-off-by: Thierry Laurion <[email protected]>
# CONFIG_BOARD_LENOVO_X220I is not set
# CONFIG_BOARD_LENOVO_X1 is not set
# CONFIG_BOARD_LENOVO_X230 is not set
CONFIG_BOARD_LENOVO_X230T=y
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only difference between x230 and x230t:

user@heads-tests-deb12-nix:~/heads$ diff config/coreboot-x230t-maximized.config config/coreboot-x230-maximized.config 
196,197c196,197
< # CONFIG_BOARD_LENOVO_X230 is not set
< CONFIG_BOARD_LENOVO_X230T=y
---
> CONFIG_BOARD_LENOVO_X230=y
> # CONFIG_BOARD_LENOVO_X230T is not set

@tlaurion
Copy link
Collaborator Author

tlaurion commented Oct 3, 2024

@fhvyhjriur another bit rotting PR without testing. I did the work but you did not test and report :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant