Add Python 3.13 compatibility #183
Merged
+61
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - `PurePath._flavour` is now known as `PurePath.parser`. - `PurePath._load_parts()` is now gone and replaced by `PurePath._raw_path`.
otetard
force-pushed
the
add-python-3.13-support
branch
from
1f3d80d to
ea880f4
Compare
Darkheir
force-pushed
the
add-python-3.13-support
branch
from
be1c0b7 to
9627e66
Compare
liormizr
reviewed
Nov 9, 2024
There was a problem hiding this comment.
Thank you for your contribution!
The only things I believe are missing are:
I think it would be cleaner for the next release to be a minor version update (0.6.0). In this version, we could remove support for the old glob algorithm entirely, as the new algorithm seems better for S3 usage anyway.
I'm also missing the related documentation update. I'll add this after we disable the old algorithm.
liormizr
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PurePath._flavouris now known asPurePath.parser.PurePath._load_parts()is now gone and replaced byPurePath._raw_path.pathlib).