Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip gf180mcu 2 #48

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Wip gf180mcu 2 #48

merged 7 commits into from
Oct 20, 2023

Conversation

jpc-lip6
Copy link
Collaborator

No description provided.

@Coloquinte Coloquinte marked this pull request as ready for review September 29, 2023 09:12
Copy link
Collaborator

@Coloquinte Coloquinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: merge any time

@robtaylor robtaylor self-requested a review October 6, 2023 12:32
The GDS file write all the cell names (SREF) in one namespace, so cells
with identical names, coming from different libraries may clash. When
a GDS is read *and* contains sub-cell, we isolate them in a sub-library,
but we must *also* give the cells in them unique names, we prefix by
the library name (which in turn is the top cell name).
@jpc-lip6 jpc-lip6 merged commit f840563 into main Oct 20, 2023
11 checks passed
@jpc-lip6 jpc-lip6 deleted the wip-gf180mcu-2 branch October 20, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants