Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/activities: prepare removal of activities app #5374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/_1111.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Removed

- **Breaking Change** prepare the removal of the activities (face2face) app and delete the
associated models and views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this breaking if there is no activities happened/happening? And reminds me that I don't have an account on mB prod.

Copy link
Contributor Author

@goapunk goapunk Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the app but as we are open source someone else could ? (not that it is very likely but I thought it would still be nice to mention it as a breaking change)

25 changes: 0 additions & 25 deletions meinberlin/apps/activities/admin.py

This file was deleted.

40 changes: 0 additions & 40 deletions meinberlin/apps/activities/dashboard.py

This file was deleted.

9 changes: 0 additions & 9 deletions meinberlin/apps/activities/forms.py

This file was deleted.

15 changes: 15 additions & 0 deletions meinberlin/apps/activities/migrations/0005_delete_activity.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Generated by Django 4.2 on 2023-12-14 13:05

from django.db import migrations


class Migration(migrations.Migration):
dependencies = [
("meinberlin_activities", "0004_alter_activity_description"),
]

operations = [
migrations.DeleteModel(
name="Activity",
),
]
34 changes: 0 additions & 34 deletions meinberlin/apps/activities/models.py

This file was deleted.

21 changes: 0 additions & 21 deletions meinberlin/apps/activities/phases.py

This file was deleted.

12 changes: 0 additions & 12 deletions meinberlin/apps/activities/rules.py

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

44 changes: 0 additions & 44 deletions meinberlin/apps/activities/views.py

This file was deleted.

14 changes: 0 additions & 14 deletions meinberlin/apps/offlineevents/templatetags/offlineevent_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

from adhocracy4.modules.models import Module
from adhocracy4.phases.models import Phase
from meinberlin.apps.activities.models import Activity
from meinberlin.apps.offlineevents.models import OfflineEvent

register = template.Library()
Expand Down Expand Up @@ -48,16 +47,3 @@ def is_module(obj):
@register.filter
def is_offlineevent(obj):
return isinstance(obj, OfflineEvent)


@register.filter
def has_activity(obj):
try:
return isinstance(obj.item_set.first().activity, Activity)
except AttributeError:
try:
return isinstance(
obj.future_phases.first().module.item_set.first().activity, Activity
)
except AttributeError:
return isinstance(obj, Activity)
12 changes: 0 additions & 12 deletions meinberlin/test/factories/activities.py

This file was deleted.

31 changes: 0 additions & 31 deletions tests/activities/test_activity_component.py

This file was deleted.

13 changes: 0 additions & 13 deletions tests/activities/test_activity_model.py

This file was deleted.

48 changes: 0 additions & 48 deletions tests/activities/test_activity_view.py

This file was deleted.

Loading