-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8875] insights: add a+ insights logic and display on project detail #6123
base: dev
Are you sure you want to change the base?
Conversation
2509b8c
to
d331c4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a comment regarding the ratings
@m4ra one thing we need to take into account that the insights data migration will take quite a long time, locally I got about 7min, from experience that might take up to 1h on prod |
@vellip needs cherry-picking because of the force-pushed migrations to dev |
ebbb69c
to
fe4c905
Compare
Added maptopics and a logger output when the migration is happening |
fe4c905
to
965b634
Compare
@goapunk hmm, might make your lives easier when it comes to deploying, yeaah. Should I take it out? |
insights = defaultdict(ProjectInsight) | ||
user_ids = defaultdict(set) | ||
|
||
logger.info("creating insights") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually prefer not to have that logging, it doesn't really help, django already tells us what migration is currently running :)
Let's take it out, yeah. If we end up needing it we can still add it later |
965b634
to
52f6fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! just a few things
52f6fc1
to
f8dda4a
Compare
show_live_questions = "IE" in blueprint_types | ||
show_ideas = bool( | ||
blueprint_types.intersection( | ||
{"BS", "IC", "MBS", "TP", "MTP", "MIC", "PB", "PB2", "PB3"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added Topic Prio and Map Topic Prio here. I hope that is right?
f8dda4a
to
b9a4d76
Compare
…dd project result page
b9a4d76
to
f032da3
Compare
also adds project result page, insight logic mostly taken from a+, with some changes. Not moved into a4 for a quicker implementation
Tasks