This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix Node Selector Resource Plugin #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sharathmk99! Can you explain your changes and why they are needed? |
Hi @aleoli, In version 0.8.x Resource plugin was providing With liqo version 0.10.x resource plugin should just provide This PR will remove pod resources calculation and provide only aggregated node resources only. |
aleoli
approved these changes
Feb 20, 2024
|
Hi @Sharathmk99, can you please squash your commits before merging? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest version of Liqo, we don't need to subtract pod resources from node resources. This PR will fix this.