Merge branch 'release/v1.0.0-rc2'

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -1,29 +1,30 @@
----
-name: Bug report
-about: Create a report to help us improve
-
----
-
-**Describe the bug**
-A clear and concise description of what the bug is.
-
-**To Reproduce**
-Steps to reproduce the behavior:
-1. Go to '...'
-2. Click on '....'
-3. Scroll down to '....'
-4. See error
-
-**Expected behavior**
-A clear and concise description of what you expected to happen.
-
-**Screenshots**
-If applicable, add screenshots to help explain your problem.
-
-**Versions**
-- WordPress version
-- WooCommerce version
-- Plugin version [e.g. "1.0.0 (Beta 3)" or "develop @ 027c6aa"]
-
-**Additional context**
-Add any other context about the problem here.
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Versions**
+- WordPress version
+- WooCommerce version
+- Plugin version [e.g. "1.0.0 (Beta 3)" or "develop @ 027c6aa"]
+- PHP version
+
+**Additional context**
+Add any other context about the problem here.

.gitignore

@@ -1,2 +1,3 @@
 tests/coverage
 vendor
+*.DS_Store

.travis.yml

@@ -10,31 +10,51 @@ cache:
     - $HOME/.composer/cache
 
 php:
+  - 7.3
   - 7.2
   - 7.1
   - 7.0
 
 env:
   - WP_VERSION=latest WC_VERSION=latest
-  - WP_VERSION=latest WC_VERSION=3.4.5
-  - WP_VERSION=latest WC_VERSION=3.3.5
-  - WP_VERSION=latest WC_VERSION=3.2.6
+  - WP_VERSION=4.9.9 WC_VERSION=latest
+  - WP_VERSION=4.9.9 WC_VERSION=3.4.7
+  - WP_VERSION=4.9.9 WC_VERSION=3.3.5
+  - WP_VERSION=4.9.9 WC_VERSION=3.2.6
 
+# Considerations for the test matrix:
+#
+# - The "WC Requires At Least" is 3.2.6, so that's the lowest we need to go
+# - WordPress < 5.0 doesn't officially support PHP 7.3.
+# - WordPress 5.0 requires at least WooCommerce 3.5.1
 matrix:
   fast_finish: true
   include:
     - name: Coding Standards
       php: 7.2
-      env: WP_VERSION=trunk WC_VERSION=latest RUN_PHPCS=1
-    # Generate code coverage from PHP 7.1.
+      env: WP_VERSION=latest WC_VERSION=latest RUN_PHPCS=1
     - name: Code Coverage
       php: 7.2
-      env: WP_VERSION=latest WP_MULTISITE=0 WC_VERSION=latest RUN_CODE_COVERAGE=1
-
+      env: WP_VERSION=latest WC_VERSION=latest RUN_CODE_COVERAGE=1
+    - name: Bleeding Edge
+      php: 7.3
+      env: WP_VERSION=trunk WC_VERSION=latest
+  exclude:
+    - php: 7.3
+      env: WP_VERSION=4.9.9 WC_VERSION=latest
+    - php: 7.3
+      env: WP_VERSION=4.9.9 WC_VERSION=3.4.7
+    - php: 7.3
+      env: WP_VERSION=4.9.9 WC_VERSION=3.3.5
+    - php: 7.3
+      env: WP_VERSION=4.9.9 WC_VERSION=3.2.6
   allow_failures:
     - name: Code Coverage
       php: 7.2
-      env: WP_VERSION=latest WP_MULTISITE=0 WC_VERSION=latest RUN_CODE_COVERAGE=1
+      env: WP_VERSION=latest WC_VERSION=latest RUN_CODE_COVERAGE=1
+    - name: Bleeding Edge
+      php: 7.3
+      env: WP_VERSION=trunk WC_VERSION=latest
 
 before_script:
   - export PATH="$HOME/.composer/vendor/bin:$PATH"
@@ -43,9 +63,8 @@ before_script:
       wget https://github.com/php-coveralls/php-coveralls/releases/download/v1.0.0/coveralls.phar
       chmod +x coveralls.phar
       mkdir -p build/logs
-    else
-      phpenv config-rm xdebug.ini
     fi
+  - phpenv config-rm xdebug.ini || true
   - |
     if [[ ${GITHUB_AUTH_TOKEN} != '' ]]; then
       composer config -g github-oauth.github.com $GITHUB_AUTH_TOKEN
@@ -57,7 +76,7 @@ before_script:
 script:
   - |
     if [[ ${RUN_CODE_COVERAGE} ]]; then
-      ./vendor/bin/phpunit --coverage-clover build/logs/clover.xml
+      phpdbg -qrr -d memory_limit=-1 ./vendor/bin/phpunit -c phpunit.xml.dist --coverage-clover=build/logs/clover.xml --exclude-group=timeout
     else
       ./vendor/bin/phpunit
     fi

CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Version 1.0.0 (Release Candidate 2)] - 2018-12-14
+
+* Reduced overhead of PHP autoloader ([#86], props @schlessera).
+* Converted the `customer_user_agent` column from `varchar(200)` to `text` ([#91]).
+* Fixed an issue where `empty()` was being called on a non-variable, which causes a fatal error in PHP < 5.5 ([#94]).
+* Prevented empty strings from being saved to the `order_key` column, which causes issues with the column's uniqueness constraint ([#101], props @crstauf).
+* Fixed an issue where *existing* invalid emails in the system were causing migration errors as they were re-saved ([#104]).
+* Updated Travis CI testing matrix to include WordPress 5.0 ([#103]).
+* Repaired the generation of code coverage reports for Coveralls ([#87], [#88]).
+
 ## [Version 1.0.0 (Release Candidate)] - 2018-09-25
 
 * Major refactoring of the WP-CLI migration commands ([#61], [#79], [#81]).
@@ -48,6 +58,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 
 [Unreleased]: https://github.com/liquidweb/woocommerce-order-tables/compare/master...develop
+[Version 1.0.0 (Release Candidate 2)]: https://github.com/liquidweb/woocommerce-order-tables/releases/tag/v1.0.0-rc2
 [Version 1.0.0 (Release Candidate)]: https://github.com/liquidweb/woocommerce-order-tables/releases/tag/v1.0.0-rc1
 [Version 1.0.0 (Beta 3)]: https://github.com/liquidweb/woocommerce-order-tables/releases/tag/v1.0.0-beta.3
 [Version 1.0.0 (Beta 2)]: https://github.com/liquidweb/woocommerce-order-tables/releases/tag/v1.0.0-beta.2
@@ -80,3 +91,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 [#81]: https://github.com/liquidweb/woocommerce-order-tables/pull/81
 [#82]: https://github.com/liquidweb/woocommerce-order-tables/pull/82
 [#84]: https://github.com/liquidweb/woocommerce-order-tables/pull/84
+[#86]: https://github.com/liquidweb/woocommerce-order-tables/pull/86
+[#87]: https://github.com/liquidweb/woocommerce-order-tables/pull/87
+[#88]: https://github.com/liquidweb/woocommerce-order-tables/pull/88
+[#91]: https://github.com/liquidweb/woocommerce-order-tables/pull/91
+[#94]: https://github.com/liquidweb/woocommerce-order-tables/pull/94
+[#101]: https://github.com/liquidweb/woocommerce-order-tables/pull/101
+[#103]: https://github.com/liquidweb/woocommerce-order-tables/pull/103
+[#104]: https://github.com/liquidweb/woocommerce-order-tables/pull/104

README.md

@@ -1,7 +1,7 @@
 # WooCommerce Custom Orders Table
 
 [![Build Status](https://travis-ci.org/liquidweb/woocommerce-custom-orders-table.svg?branch=develop)](https://travis-ci.org/liquidweb/woocommerce-custom-orders-table)
-[![Coverage Status](https://coveralls.io/repos/github/liquidweb/woocommerce-custom-orders-table/badge.svg?branch=feature%2Fcode-coverage)](https://coveralls.io/github/liquidweb/woocommerce-custom-orders-table?branch=feature%2Fcode-coverage)
+[![Coverage Status](https://coveralls.io/repos/github/liquidweb/woocommerce-custom-orders-table/badge.svg?branch=develop)](https://coveralls.io/github/liquidweb/woocommerce-custom-orders-table?branch=develop)
 
 This plugin improves WooCommerce performance by introducing a custom table to hold all of the most common order information in a single, properly-indexed location.
 

composer.json

@@ -6,13 +6,13 @@
   "require-dev": {
     "php": "^7.0",
     "dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
-    "phpunit/phpunit": "6.2.3",
-    "wimg/php-compatibility": "^8.1",
+    "phpunit/phpunit": "^6.5",
+    "wimg/php-compatibility": "^9.0",
     "woocommerce/woocommerce": "dev-master",
     "woocommerce/woocommerce-git-hooks": "*",
-    "woocommerce/woocommerce-sniffs": "^0.0.1",
+    "woocommerce/woocommerce-sniffs": "^0.0.2",
     "wp-cli/wp-cli": "^2.0",
-    "wp-coding-standards/wpcs": "^0.14"
+    "wp-coding-standards/wpcs": "^1.1"
   },
   "autoload-dev": {
     "classmap": [
@@ -40,10 +40,13 @@
       "phpunit --testsuite=plugin --coverage-html=tests/coverage"
     ]
   },
+  "scripts-descriptions": {
+    "test-coverage": "Generate test coverage for the plugin"
+  },
   "config": {
       "sort-packages": true,
       "platform": {
-          "php": "7.0"
+          "php": "7.2"
       }
   },
   "extra": {