-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added subprocess test client #3655
feat: added subprocess test client #3655
Conversation
Tests are failing because the redis fixture does not seem to work correctly. Tbh, added that as a best guess, so would need some help with fixing this. Alternatively, I just replace the test with a regular "does it connect and return the right thing" kind of test and ditch the SSE testing. No idea why doc generation is failing. |
cc: @litestar-org/maintainers thought? |
cd6443e
to
469a572
Compare
469a572
to
7366207
Compare
e4bc209
to
baee5d7
Compare
e61cd34
to
7a0659b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified the test case a bit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3655 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 346 347 +1
Lines 15690 15722 +32
Branches 1737 1737
=======================================
+ Hits 15433 15465 +32
Misses 122 122
Partials 135 135 ☔ View full report in Codecov by Sentry. |
@all-contributors add @aranvir for docs, code, tests |
I've put up a pull request to add @aranvir! 🎉 |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3655 |
Description
This introduces new helper functions to create sync and async test clients that can be used to test SSE endpoints with infinite generators as outlined in #3654 and https://github.com/orgs/litestar-org/discussions/3547.
The litestar cli is run in a subprocess to start a web app instance with a random port. The helper function then sets up a basic sync or async client.
The test code and doc example show how this can be used to test an SSE endpoint with an infinite generator.
Overview:
subprocess_async_client
andsubprocess_sync_client
subprocess_async_client
Closes
Closes #3654