Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only digits on the OTP fields #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DeeTheDev
Copy link
Collaborator

Fixes #762

When any non-digit values is detected, reset the value to the previous value - effectively preventing non-digits from being inputed.

  • Fix aria-label to use markdown ex: "Enter code 1"
  • Use input type numbers

@DeeTheDev DeeTheDev added bug Something isn't working webapp Public frontend changes labels Feb 12, 2025
@DeeTheDev DeeTheDev requested a review from rgalanakis February 12, 2025 03:15
@DeeTheDev DeeTheDev self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (ee4a62e) to head (b6b35c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         478      478              
  Lines       21928    21942      +14     
==========================================
+ Hits        21660    21673      +13     
- Misses        268      269       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working webapp Public frontend changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug that allows letters in the OTP
1 participant