chore(unit): Adding units to the duration fields (#459)

Signed-off-by: Shubham Chaudhary <[email protected]>
litmuschaos · Apr 18, 2023 · c583b2b · c583b2b
1 parent 184224e
commit c583b2b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 22 deletions.
diff --git a/api/litmuschaos/v1alpha1/chaosengine_types.go b/api/litmuschaos/v1alpha1/chaosengine_types.go
@@ -29,7 +29,7 @@ type ChaosEngineSpec struct {
 	Appinfo ApplicationParams `json:"appinfo,omitempty"`
 	//DefaultHealthCheck defines whether default health checks should be executed or not. It can be true or false
 	// default value is true
-	DefaultHealthCheck string `json:"defaultHealthCheck,omitempty"`
+	DefaultHealthCheck bool `json:"defaultHealthCheck,omitempty"`
 	//ChaosServiceAccount is the SvcAcc specified for chaos runner pods
 	ChaosServiceAccount string `json:"chaosServiceAccount"`
 	//Components contains the image, imagePullPolicy, arguments, and commands of runner
@@ -419,21 +419,21 @@ type PostMethod struct {
 // RunProperty contains timeout, retry and interval for the probe
 type RunProperty struct {
 	//ProbeTimeout contains timeout for the probe
-	ProbeTimeout int `json:"probeTimeout,omitempty"`
+	ProbeTimeout string `json:"probeTimeout,omitempty"`
 	// Interval contains the interval for the probe
-	Interval int `json:"interval,omitempty"`
+	Interval string `json:"interval,omitempty"`
 	// Retry contains the retry count for the probe
 	Retry int `json:"retry,omitempty"`
 	// Attempt contains the total attempt count for the probe
 	Attempt int `json:"attempt,omitempty"`
 	//ProbePollingInterval contains time interval, for which continuous probe should be sleep
 	// after each iteration
-	ProbePollingInterval int `json:"probePollingInterval,omitempty"`
+	ProbePollingInterval string `json:"probePollingInterval,omitempty"`
 	//InitialDelaySeconds time interval for which probe will wait before run
-	InitialDelaySeconds int `json:"initialDelaySeconds,omitempty"`
+	InitialDelay string `json:"initialDelay,omitempty"`
 	// EvaluationTimeout is the timeout window in which the SLO metrics
 	// will be fetched and will be evaluated
-	EvaluationTimeout int `json:"evaluationTimeout,omitempty"`
+	EvaluationTimeout string `json:"evaluationTimeout,omitempty"`
 	// StopOnFailure contains flag to stop/continue experiment execution, if probe fails
 	// it will stop the experiment execution, if provided true
 	// it will continue the experiment execution, if provided false or not provided(default case)

diff --git a/deploy/chaos_crds.yaml b/deploy/chaos_crds.yaml
@@ -41,8 +41,7 @@ spec:
                 #  - pattern: '^delete$'
                 #  - pattern: '^retain$'
               defaultHealthCheck:
-                type: string
-                pattern: ^(true|false)$ 
+                type: boolean
               appinfo:
                 type: object
                 properties:
@@ -2229,19 +2228,19 @@ spec:
                                   - interval
                                 properties:
                                   evaluationTimeout:
-                                    type: integer
+                                    type: string
                                   probeTimeout:
-                                    type: integer
+                                    type: string
                                   interval:
-                                    type: integer
+                                    type: string
                                   retry:
                                     type: integer
                                   attempt:
                                     type: integer
                                   probePollingInterval:
-                                    type: integer
-                                  initialDelaySeconds:
-                                    type: integer
+                                    type: string
+                                  initialDelay:
+                                    type: string
                                   stopOnFailure:
                                     type: boolean
                               sloProbe/inputs:

diff --git a/deploy/crds/chaosengine_crd.yaml b/deploy/crds/chaosengine_crd.yaml
@@ -40,8 +40,7 @@ spec:
                 #  - pattern: '^delete$'
                 #  - pattern: '^retain$'
               defaultHealthCheck:
-                type: string
-                pattern: ^(true|false)$
+                type: boolean
               appinfo:
                 type: object
                 properties:
@@ -2227,19 +2226,19 @@ spec:
                                   - interval
                                 properties:
                                   evaluationTimeout:
-                                    type: integer
+                                    type: string
                                   probeTimeout:
-                                    type: integer
+                                    type: string
                                   interval:
-                                    type: integer
+                                    type: string
                                   retry:
                                     type: integer
                                   attempt:
                                     type: integer
                                   probePollingInterval:
-                                    type: integer
-                                  initialDelaySeconds:
-                                    type: integer
+                                    type: string
+                                  initialDelay:
+                                    type: string
                                   stopOnFailure:
                                     type: boolean
                               sloProbe/inputs: