added check logic before splitting via comma separator #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
neelanjan00
requested changes
Jan 29, 2024
| @@ -53,6 +54,9 @@ func PrepareAWSSSMChaosByID(experimentsDetails *experimentTypes.ExperimentDetail | |||
| go lib.AbortWatcher(experimentsDetails, abort) | |||
|
|
|||
| //get the instance id or list of instance ids | |||
| if strings.TrimSpace(experimentsDetails.EC2InstanceID) == "" { | |||
| return errors.Errorf("no instance id found for chaos injection") | |||
| } | |||
| instanceIDList := strings.Split(experimentsDetails.EC2InstanceID, ",") | |||
| if experimentsDetails.EC2InstanceID == "" || len(instanceIDList) == 0 { | |||
There was a problem hiding this comment.
This check is redundant now, please check in other places too. Also, we should handle an edge case where the input contains only one or more commas. For example, strings.Split of "," will give us a string slice containing two whitespaces.
Signed-off-by: Kartikay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #555
Added check logic before split function