Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refector: refectoring code to improve the readability and quality #4465

Closed
wants to merge 0 commits into from

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Feb 22, 2024

Proposed changes

  • add cancel function return to avoid a context leak
  • replace deprecated package
    • ioutil -> io
  • simplify conditional expressions
  • simplify if statements
  • fix comments
  • change variable from snake case to camel case
  • add context.TODO()

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@Saranya-jena
Copy link
Contributor

Hi @yj-yoo , can you please resolve the conflicts? And I see you have added changes in litmus-portal, litmus-portal will be archived soon, can you add those changes in chaoscenter if applicable?

@yj-yoo
Copy link
Contributor Author

yj-yoo commented Mar 5, 2024

Hi @yj-yoo , can you please resolve the conflicts? And I see you have added changes in litmus-portal, litmus-portal will be archived soon, can you add those changes in chaoscenter if applicable?

Even though it is a simple grammar correction, do I need to add it to "chaoscenter"? Where can I find out how to add more?

@Saranya-jena
Copy link
Contributor

Actually we have removed litmus-portal as it was deprecated. Let me know how you would like to proceed. @yj-yoo

@yj-yoo
Copy link
Contributor Author

yj-yoo commented Apr 4, 2024

@Saranya-jena When will 'litmus-portal' be deprecated? I think I'll be able to send the pr again next week. If it gets deprecated first, I'll work on it again.

@Saranya-jena
Copy link
Contributor

@Saranya-jena When will 'litmus-portal' be deprecated? I think I'll be able to send the pr again next week. If it gets deprecated first, I'll work on it again.

It's already deprecated and removed from the repo @yj-yoo . Feel free to send a PR on chaoscenter changes :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants