-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Fix graphql server path injection #4809
Open
moggaa
wants to merge
4
commits into
litmuschaos:master
Choose a base branch
from
moggaa:fix/handler-path-injection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+198
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moggaa
force-pushed
the
fix/handler-path-injection
branch
2 times, most recently
from
August 4, 2024 06:53
61b02d3
to
67fadc1
Compare
namkyu1999
changed the title
fix: chaoshub handler path injection
[Security] Fix chaoshub handler path injection
Aug 4, 2024
moggaa
force-pushed
the
fix/handler-path-injection
branch
from
August 18, 2024 11:46
67fadc1
to
4718dfa
Compare
moggaa
force-pushed
the
fix/handler-path-injection
branch
from
October 5, 2024 08:14
4718dfa
to
d920302
Compare
moggaa
changed the title
[Security] Fix chaoshub handler path injection
[Security] Fix graphql server path injection
Oct 5, 2024
Signed-off-by: Jaeyeon Park <[email protected]>
Signed-off-by: Jaeyeon Park <[email protected]>
Signed-off-by: Jaeyeon Park <[email protected]>
Signed-off-by: Jaeyeon Park <[email protected]>
moggaa
force-pushed
the
fix/handler-path-injection
branch
from
October 9, 2024 07:58
91b2cad
to
4af4f67
Compare
namkyu1999
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
sanitize.PathName
function to ensure a formatted, compliant path name, addressing the vulnerability.Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: