Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subscriber k8s fuzz test #4912

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

inpyu
Copy link
Contributor

@inpyu inpyu commented Oct 3, 2024

Proposed changes

add fuzz test in /chaoscenter/graphql/server/pkg/k8s

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@namkyu1999
Copy link
Member

Can you check a build pipeline? @inpyu

Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first attempts. We need to use fake client for these cases because this pkg depends on kubeclient.

Comment on lines 19 to 25
if KubeConfig == nil {
return rest.InClusterConfig()
}

if *KubeConfig == "" {
return rest.InClusterConfig()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if KubeConfig == nil {
return rest.InClusterConfig()
}
if *KubeConfig == "" {
return rest.InClusterConfig()
}
if *KubeConfig == "" || KubeConfig == nil {
return rest.InClusterConfig()
}

@@ -14,11 +16,19 @@ var KubeConfig *string

// getKubeConfig setup the config for access cluster resource
func (k8s *k8sSubscriber) GetKubeConfig() (*rest.Config, error) {
// Use in-cluster config if kubeconfig path is not specified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep this line?

@inpyu inpyu marked this pull request as draft October 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants