Skip to content

Commit

Permalink
Update RSpec setup
Browse files Browse the repository at this point in the history
Regenerate the RSpec spec helper and modernize the config.
  • Loading branch information
liveh2o committed Dec 15, 2024
1 parent 8e3f319 commit b36677b
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 18 deletions.
1 change: 0 additions & 1 deletion lib/protobuf/active_record/columns.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "set"
require "active_support/concern"

module Protobuf
Expand Down
1 change: 0 additions & 1 deletion lib/protobuf/active_record/serialization.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "set"
require "active_support/concern"

module Protobuf
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/columns_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "spec_helper"

describe Protobuf::ActiveRecord::Columns do
RSpec.describe Protobuf::ActiveRecord::Columns do
describe "._protobuf_map_columns" do
context "when the class has a table" do
let(:expected_column_names) {
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/nested_attributes_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "spec_helper"

describe Protobuf::ActiveRecord::NestedAttributes do
RSpec.describe Protobuf::ActiveRecord::NestedAttributes do
let(:user_message) {
UserMessage.new(name: "foo bar", email: "[email protected]", photos: [{url: "https://test.co/test.png"}])
}
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/persistence_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "spec_helper"

describe Protobuf::ActiveRecord::Persistence do
RSpec.describe Protobuf::ActiveRecord::Persistence do
let(:user) { User.new(user_attributes) }
let(:user_attributes) { {first_name: "foo", last_name: "bar", email: "[email protected]"} }
let(:proto_hash) { {name: "foo bar", email: "[email protected]"} }
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/scope_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class TheMessage < ::Protobuf::Message
optional TheEnum, :the_enum_value, 1
end

describe Protobuf::ActiveRecord::Scope do
RSpec.describe Protobuf::ActiveRecord::Scope do
before do
@field_parsers = User.instance_variable_get(:@_searchable_field_parsers)
@fields = User.instance_variable_get(:@_searchable_fields)
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/serialization_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class UnconfiguredUser
include Protobuf::ActiveRecord::Model
end

describe Protobuf::ActiveRecord::Serialization do
RSpec.describe Protobuf::ActiveRecord::Serialization do
let(:protobuf_message) { UserMessage }

describe ".field_from_record" do
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/transformation_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "spec_helper"

describe Protobuf::ActiveRecord::Transformation do
RSpec.describe Protobuf::ActiveRecord::Transformation do
let(:user) { User.new(user_attributes) }
let(:user_attributes) { {first_name: "foo", last_name: "bar", email: "[email protected]"} }
let(:proto_hash) { {name: "foo bar", email: "[email protected]"} }
Expand Down
2 changes: 1 addition & 1 deletion spec/protobuf/active_record/transformer_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "spec_helper"

describe ::Protobuf::ActiveRecord::Transformer do
RSpec.describe ::Protobuf::ActiveRecord::Transformer do
let(:callable) { lambda { |proto| proto.name } }
let(:proto) { ::UserMessage.new(name: "test", nullify: ["name"]) }
let(:options) { {} }
Expand Down
27 changes: 18 additions & 9 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
require "rubygems"
require "bundler"
# frozen_string_literal: true

require "simplecov"
SimpleCov.start do
add_filter "/spec/"
end

Bundler.require(:default, :development, :test)
require "protobuf-activerecord"
require "timecop"

require "support/db"
require "support/models"
Expand All @@ -16,12 +16,21 @@
Protobuf::Logging.logger.level = ::Logger::FATAL

RSpec.configure do |config|
# Turn deprecation warnings into errors with full backtrace.
config.raise_errors_for_deprecations!
# Enable flags like --only-failures and --next-failure
config.example_status_persistence_file_path = ".rspec_status"

# Disable RSpec exposing methods globally on `Module` and `main`
config.disable_monkey_patching!

config.expect_with :rspec do |c|
c.syntax = :expect
end

# Verifies the existance of any stubbed methods, replaces better_receive and better_stub
# https://www.relishapp.com/rspec/rspec-mocks/v/3-1/docs/verifying-doubles/partial-doubles
config.mock_with :rspec do |mocks|
mocks.verify_partial_doubles = true
# Verify the existence of any stubbed methods
config.mock_with :rspec do |c|
c.verify_partial_doubles = true
end

# Turn deprecation warnings into errors with full backtrace.
config.raise_errors_for_deprecations!
end

0 comments on commit b36677b

Please sign in to comment.