set nullify to empty array to address protobuf 4 deprecation warning #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogman1
commented
Aug 11, 2022
|
Assuming this is reasonable, any chance this could be back-ported to at least v6.0? |
mogman1
force-pushed
the
sc/support_protobuf4_nullify
branch
from
f1794d7 to
86bbea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf issues a deprecation warning about setting the
nullifyfield toniland instead suggests using an empty array:So...I did that. I also tried to handle for the case when it just so happens that an activerecord object defines a
nullifyattribute that this value still comes through.